-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue with data files not being copied to the installation directory #34
Conversation
Just FYI, @zacharyburnettNOAA, I haven't tested this yet due to HTTP issue. |
@zacharyburnettNOAA this fix seems to be working. How can I force rerunning the tests? Since the failure was due to the website being down |
@zacharyburnettNOAA I found out how to rerun the tests but then I noticed that tests fail even in |
i've made a few fixes to URL handling; it was an issue with the realtime best track directory (https://ftp.nhc.noaa.gov/atcf/btk) being cleared (the best tracks that were there were moved to the archive) |
for some reason the tests are now hanging indefinitely on GitHub Actions, but run fine on my local machine I am working on setting up local docker containers to test this |
Codecov Report
@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 90.66% 89.78% -0.89%
==========================================
Files 22 22
Lines 2079 2125 +46
==========================================
+ Hits 1885 1908 +23
- Misses 194 217 +23
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, tests pass
This issue shows up when testing getting COOPS stations using PyPI installed version of the package (not when using repo dev version).
While testing the fix, HTTP requests failed resulting in strange errors from user perspective. Added checks to raise better exceptions when HTTP requests fail when fetching data