Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue with data files not being copied to the installation directory #34

Merged
3 commits merged into from
Apr 12, 2022

Conversation

SorooshMani-NOAA
Copy link
Collaborator

This issue shows up when testing getting COOPS stations using PyPI installed version of the package (not when using repo dev version).

While testing the fix, HTTP requests failed resulting in strange errors from user perspective. Added checks to raise better exceptions when HTTP requests fail when fetching data

@SorooshMani-NOAA
Copy link
Collaborator Author

Just FYI, @zacharyburnettNOAA, I haven't tested this yet due to HTTP issue.

@SorooshMani-NOAA
Copy link
Collaborator Author

@zacharyburnettNOAA this fix seems to be working. How can I force rerunning the tests? Since the failure was due to the website being down

@SorooshMani-NOAA SorooshMani-NOAA requested a review from a user April 8, 2022 12:51
@SorooshMani-NOAA
Copy link
Collaborator Author

@zacharyburnettNOAA I found out how to rerun the tests but then I noticed that tests fail even in main branch. Please let me know how you want to proceed with this pull request given the failures. Thanks

@ghost
Copy link

ghost commented Apr 11, 2022

i've made a few fixes to URL handling; it was an issue with the realtime best track directory (https://ftp.nhc.noaa.gov/atcf/btk) being cleared (the best tracks that were there were moved to the archive)

@ghost
Copy link

ghost commented Apr 11, 2022

for some reason the tests are now hanging indefinitely on GitHub Actions, but run fine on my local machine

I am working on setting up local docker containers to test this

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #34 (760d98a) into main (1a32b4a) will decrease coverage by 0.88%.
The diff coverage is 84.14%.

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   90.66%   89.78%   -0.89%     
==========================================
  Files          22       22              
  Lines        2079     2125      +46     
==========================================
+ Hits         1885     1908      +23     
- Misses        194      217      +23     
Impacted Files Coverage Δ
tests/test_atcf.py 100.00% <ø> (ø)
tests/test_nhc.py 97.01% <ø> (-2.99%) ⬇️
tests/test_stormevent.py 98.30% <ø> (-0.02%) ⬇️
stormevents/nhc/storms.py 79.54% <55.17%> (-17.64%) ⬇️
stormevents/stormevent.py 95.54% <81.81%> (+0.05%) ⬆️
stormevents/nhc/track.py 89.49% <88.13%> (-1.82%) ⬇️
stormevents/nhc/atcf.py 91.97% <100.00%> (+4.55%) ⬆️
stormevents/usgs/events.py 80.39% <100.00%> (-0.13%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21c80f...760d98a. Read the comment docs.

@ghost ghost merged commit 0779112 into main Apr 12, 2022
@ghost ghost deleted the fix/pkg_data branch April 12, 2022 17:32
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, tests pass

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants